[Not-urgent] LF-4380 - address comments and improvement suggestions #3510
+106
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
…values in oneOf schemas, update comments
Duncan-Brain
requested review from
antsgar and
SayakaOno
and removed request for
a team
Duncan-Brain
changed the title
SayakaOno
reviewed
Nov 29, 2024
| ); | ||
| const isCreatingWithBreed = | ||
| creating && someTruthy([default_breed_id, custom_breed_id, breed_name]); | ||
| // Do checks on breed unless removing breed from existing record or |
There was a problem hiding this comment.
"Do checks on breed unless removing breed from existing record" - it seems to me that the next line can simply be if(someTruthy([default_breed_id, custom_breed_id, breed_name]).
I got confused here and I may have misunderstood something.
| ); | ||
| } | ||
| // Check if custom breed or new type is present | ||
| // Skip checks in some cases where new custom type or breed is added | ||
| if ((custom_breed_id && !type_name) || ((default_type_id || custom_type_id) && !breed_name)) { |
There was a problem hiding this comment.
The combination of breed ID and type_name is wrong... isn't it already handled earlier? I'm wondering if it can be if (custom_breed_id || ((default_type_id || custom_type_id) && !breed_name))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira link: LF-4380
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: