Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Infobox.less): make Smash infobox colors dark-mode compatible #5297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

iamentry
Copy link
Collaborator

Summary

Smash infoboxes are colored depending on which game is entered in the infobox. This PR makes them dark-mode compatible.

Example of just one of the changes
Before
Screenshot 2025-01-10 113316
Screenshot 2025-01-10 113339

After
Screenshot 2025-01-10 113433
Screenshot 2025-01-10 113454

How did you test this change?

Inspect tool

@iamentry iamentry added c: infobox stylesheets changes to stylesheets labels Jan 10, 2025
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the old colors as fallbacks
else stuff breaks on the current (old) skin

@iamentry iamentry requested a review from hjpalpha January 10, 2025 18:34
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infobox stylesheets changes to stylesheets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants