feat(match2): Add non-BR support for Fortnite #5244
+116
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fortnite doesn't really have a permanently set mode, because they changed all the time e.g. at the time of this PR competitions is in Duos, but by 2025 they are using Trios (as non team) instead (and could changed again in future)
hjpalpha
reviewed
Dec 25, 2024
| ---@param games table[] | ||
| ---@return table[] | ||
| function MatchFunctions.removeUnsetMaps(games) | ||
| return Array.filter(games, function(map) |
There was a problem hiding this comment.
why check for map.map being set?
can it happen that it is unset in a valid map?
maybe an Logic.isNotDeepEmpty check would be better
- use commons bestof - not sure what to do with unset maps, but try removing it and nothing breaks - empty lines seems like typo from me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I want it like how TFT is able to display both Brackets and Battle Royale together. So like #5196 in reverse
I'm starting with using TFT's setup as basis, because I never edit BR-related match2 yet
Side Note
things like
OPPONENT_CONFIGon matchFunctions is carried from FN's current setupFN doesnt really have a strict default mode (FOR BR), they changed pretty regularly
(e.g. Duos in 2024, but Trios in 2025)after talking to hjp I've come to a decision to left it unset for BRHow did you test this change?
DEV https://liquipedia.net/fortnite/User:Hesketh2/Test
Test includes putting both BR and Bracket on same page with same dev on both