feat(stylesheets): change var for bg-first #5243
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamentry
changed the title
hjpalpha
reviewed
Dec 23, 2024
That is the fallback value for the class I changed it to |
that doesn't mean you need to change the fallback value at all ... |
hjpalpha
reviewed
Dec 25, 2024
|
Changed back to the original fallback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current var for
bg-firstis unreadable in darkmode so this switches to a more readable version. I'm not sure if this is the intended use case forachievement-placement-1but it looks good IMO. The attached images display the PR's changes via the "First" text. You can see what the current version is here: https://liquipedia.net/commons/Template:BgcolortextHow did you test this change?
inspect tools