Set up mainpage data layout Deadlock #5219
Conversation
| return { | ||
| main = { | ||
| { -- Left | ||
| size = 6, |
There was a problem hiding this comment.
Consider to assign more space to the right side and reduce this to e.g. 5, as otherwise (depending on the display resolution) there isn't really enough space for the tournaments list:
That one could also benefit of removed padding on it's panel.
There was a problem hiding this comment.
@mbergen Which panel specifically did you mean to have removed padding?
There was a problem hiding this comment.
5 doesn't work I think, has to be a number dividable by 12 (1, 2, 3, 4, 6, 12)
There was a problem hiding this comment.
you mean 12 dividable by it ;)
There was a problem hiding this comment.
Which panel specifically did you mean to have removed padding?
The tournaments list panel, the padding looks weird anyways since the header bars for upcoming/ongoing/concluded don't extend to the edge
There was a problem hiding this comment.
5 doesn't work I think, has to be a number dividable by 12 (1, 2, 3, 4, 6, 12)
Sure it does, you can choose any number between 1 and 12. You just have to see that the total of all columns you want in the row is less or equal to 12, as otherwise they are wrapped to another row.
There was a problem hiding this comment.
So I did look at it with removing the padding, however to me it then seems pretty off / fall out of the design. (Moreso noticeable on darkmode
| children = { | ||
| { | ||
| mobileOrder = 1, | ||
| content = CONTENT.aboutEsport, |
There was a problem hiding this comment.
This content doesn't seem to exist
| }, | ||
| }, | ||
| { | ||
| mobileOrder = 4, |
There was a problem hiding this comment.
There's two things with mobile order 4
| padding = true, | ||
| boxid = 1510, | ||
| }, | ||
| specialEvents = { |
There was a problem hiding this comment.
Why no boxid on special events? Makes it non collaps-able
There was a problem hiding this comment.
Testing this live here; https://liquipedia.net/deadlock/Module:MainPageLayout/data Added a boxid but it doesn't seem to add a collapse to the special event box. (In this case special event is just the heroes)
Summary
Setting up the data for the Deadlock Mainpage revamp:
How did you test this change?
https://liquipedia.net/deadlock/User:Kanoodles/TestTest