Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(match2): remove temp workaround after cleanup #5201

Merged
merged 2 commits into from
Dec 13, 2024
Merged

chore(match2): remove temp workaround after cleanup #5201

merged 2 commits into from
Dec 13, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Dec 12, 2024 •
edited
Loading

Summary

remove the temp workaround after fixing all usages

How did you test this change?

N/A

@hjpalpha hjpalpha requested a review from Rathoz December 12, 2024 16:30
@hjpalpha hjpalpha marked this pull request as ready for review December 12, 2024 16:30
Rathoz
Rathoz approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can more of the "noscore" stuff be removed? Like the check later in the function doesn't seem to be necessary?

@hjpalpha hjpalpha requested a review from Rathoz December 12, 2024 16:38
@Rathoz Rathoz merged commit d5988ea into main Dec 13, 2024
5 checks passed
@Rathoz Rathoz deleted the sc2-ffa-input-processing-remove-workaround branch December 13, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rathoz Rathoz Rathoz approved these changes

Assignees
No one assigned
Labels
c: match2 g: starcraft Starcraft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpalpha @Rathoz