Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): support underlords #5187

Merged
merged 11 commits into from
Dec 10, 2024
Merged

feat(match2): support underlords #5187

merged 11 commits into from
Dec 10, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Dec 10, 2024

Summary

Add support for Underlords.

Since most all tournament in the FFA games (like TFT, underlords and autochess) do not have kill points, we need an option to not show and handle the kill points. So achieve this, restructred how the points are parsed and stored.

How did you test this change?

https://liquipedia.net/underlords/User:Rathoz#Grand_Finals & Core changes tested by Kano

@Rathoz Rathoz requested a review from hjpalpha December 10, 2024 13:05
@Rathoz Rathoz marked this pull request as ready for review December 10, 2024 13:05
@Rathoz Rathoz marked this pull request as draft December 10, 2024 13:51
Base automatically changed from standard-ffa-map to main December 10, 2024 14:11
@Rathoz Rathoz marked this pull request as ready for review December 10, 2024 14:55
@Rathoz Rathoz requested review from hjpalpha and removed request for hjpalpha December 10, 2024 14:56
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaks sc(2)!

components/match2/commons/match_group_input_util.lua Outdated Show resolved Hide resolved
components/match2/commons/match_group_input_util.lua Outdated Show resolved Hide resolved
@Rathoz Rathoz requested a review from hjpalpha December 10, 2024 15:49
@Rathoz Rathoz merged commit ee78a94 into main Dec 10, 2024
5 checks passed
@Rathoz Rathoz deleted the m2-underlods branch December 10, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants