Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(match2): match summary createBody A-G #4948

Merged
merged 2 commits into from
Oct 24, 2024
Merged

refactor(match2): match summary createBody A-G #4948

merged 2 commits into from
Oct 24, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 22, 2024

Summary

Wikis that have other elements in the range have not been refactored (such as counterstrike)

How did you test this change?

Preview tested half of them

Base automatically changed from subbmaries-minor-clean to main October 23, 2024 09:46
@Rathoz Rathoz requested a review from hjpalpha October 23, 2024 09:59
@Rathoz Rathoz requested a review from mbergen October 23, 2024 11:31
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could change local showCountdown = match.timestamp ~= DateExt.defaultTimestamp to local showCountdown = not DateExt.isDefaultTimestamp(match.timestamp)

but completely optional

@Rathoz Rathoz merged commit 5b60717 into main Oct 24, 2024
6 checks passed
@Rathoz Rathoz deleted the body-a-to-g branch October 24, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants