Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(match2) Display games with resulttype but no winner on AoE #4920

Merged
merged 1 commit into from
Oct 19, 2024
Merged

fix(match2) Display games with resulttype but no winner on AoE #4920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion components/match2/wikis/ageofempires/match_summary.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ local Logic = require('Module:Logic')
local Lua = require('Module:Lua')
local MapMode = require('Module:MapMode')
local Operator = require('Module:Operator')
local String = require('Module:StringUtils')
local Table = require('Module:Table')

local DisplayHelper = Lua.import('Module:MatchGroup/Display/Helper')
Expand Down Expand Up @@ -68,7 +69,7 @@ function CustomMatchSummary.createBody(match)
end

Array.forEach(match.games, function(game)
if not game.map and not game.winner then return end
if not game.map and not game.winner and String.isNotEmpty(game.resulttype) then return end
local row = MatchSummary.Row()
:addClass('brkts-popup-body-game')
:css('font-size', '0.75rem')
Expand Down
Loading