Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(widget): abbr widget's title #4917

Merged
merged 5 commits into from
Oct 22, 2024
Merged

fix(widget): abbr widget's title #4917

merged 5 commits into from
Oct 22, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 19, 2024

Summary

Since refactoring the HTML Widgets in a previous PR, abbr's title have to been in attributes = {title = ...} which was not intended. Readding the title = ... input.

How did you test this change?

Busted

@Rathoz Rathoz changed the title fix(widget): attr's widget fix(widget): abbr widget Oct 21, 2024
@Rathoz Rathoz changed the title fix(widget): abbr widget fix(widget): abbr widget's title Oct 21, 2024
@Rathoz Rathoz requested a review from hjpalpha October 21, 2024 12:12
@Rathoz Rathoz marked this pull request as ready for review October 21, 2024 12:12
components/widget/html/widget_html_all.lua Show resolved Hide resolved
spec/widgets/html_spec.lua Outdated Show resolved Hide resolved
@Rathoz Rathoz requested a review from hjpalpha October 21, 2024 15:55
@Rathoz Rathoz merged commit 8de5630 into main Oct 22, 2024
5 checks passed
@Rathoz Rathoz deleted the fix-attr-widget branch October 22, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants