fix(match2): display on bracket template pages still off #4913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think you need to undo the last commit on this branch |
|
oh fuck, yeah |
hjpalpha
force-pushed
the
really-fix-display-on-bracket-template-pages
branch
from
b924473 to
b5304f8
Compare
Rathoz
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
need to insert the opponents before making the records a match group so that coordinates for the lines between matches get drawn properly
can not use plain opponnet.blank due to:
MatchGroupUtil.makeMatchGrouperrorsmatch2opponent:LpdbBaseDataobjectHow did you test this change?
dev to live