Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(transfer): flag processing not perfect #4903

Merged
merged 3 commits into from
Oct 18, 2024
Merged

fix(transfer): flag processing not perfect #4903

merged 3 commits into from
Oct 18, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 18, 2024

Summary

  • shut up an anno warning in transfer display
  • switch from countrycode to countryname for storage/processing
    • can't use alpha2 country code due to it not supporting the shitty uk sub flag stuff
    • can't use alpha3 country code due to it not supporting:
--   ISO 3166-1 alpha-2 User-assigned Code Elements
['xk'] = 'kosovo',
['xx'] = 'nonrepresenting',

alternative solution would be to add user assigned alpha3 country codes for those 2 cases... (xkx for Kosovo and xxx for non rep)
lmk if that is prefered

How did you test this change?

untested on wki, don't have the time atm
golden/smoke tests should be enough

@Rathoz Rathoz merged commit 363dc8d into main Oct 18, 2024
5 checks passed
@Rathoz Rathoz deleted the transfer-fix branch October 18, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants