Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(match2): make a display widget of the match page link #4888

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Oct 16, 2024

Summary

Extract the Match Page Link to a common display widget

How did you test this change?

tested on lol

@Rathoz Rathoz requested a review from hjpalpha October 16, 2024 18:03
@hjpalpha
Copy link
Collaborator

hjpalpha commented Oct 16, 2024

fwiw busted errors

nonetheless lgtm on phone

@Rathoz Rathoz requested review from hjpalpha and removed request for hjpalpha October 17, 2024 15:45
Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if tested

@Rathoz Rathoz merged commit 604d831 into main Oct 18, 2024
5 checks passed
@Rathoz Rathoz deleted the match-page-widget branch October 18, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants