Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(match2): tournament_status is not working #4881

Merged
merged 6 commits into from
Oct 23, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Oct 16, 2024

Summary

Fix the status/finished processing on cs by applying fallbacks a bit differently and moving status processing further up.
Also allow 'postponed' as valid not played input

How did you test this change?

dev

Copy link
Collaborator

@iMarbot iMarbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find where it was tested on dev but I tested it myself too and works 👍

@hjpalpha
Copy link
Collaborator Author

I couldn't find where it was tested on dev but I tested it myself too and works 👍

/dev/hjp but i deleted it after testing

@hjpalpha hjpalpha requested a review from Rathoz October 17, 2024 08:26
@hjpalpha hjpalpha requested a review from Rathoz October 21, 2024 08:51
@hjpalpha hjpalpha requested a review from Rathoz October 22, 2024 06:00
@iMarbot
Copy link
Collaborator

iMarbot commented Oct 22, 2024

Is postponed still a valid input (just without setting notplayed) or invalid entirely?

@hjpalpha
Copy link
Collaborator Author

Is postponed still a valid input (just without setting notplayed) or invalid entirely?

postponed is oos for this PR

@iMarbot
Copy link
Collaborator

iMarbot commented Oct 22, 2024

postponed is oos for this PR

so, invalid entirely? I just want to understand the current state, that's all.

@Rathoz
Copy link
Collaborator

Rathoz commented Oct 23, 2024

postponed is oos for this PR

so, invalid entirely? I just want to understand the current state, that's all.

Yes, this PR does not improve or add support for postponed. It does however add support for tournament_status as a replacement for |finished=, so valid inputs to |finished= (true/false/np/skip/cancelled/canceled) are parsed

@Rathoz Rathoz changed the title fix(match2): finished/status processing faulty on cs fix(match2): tournament_status is not working Oct 23, 2024
@Rathoz Rathoz merged commit 6a67a09 into main Oct 23, 2024
5 checks passed
@Rathoz Rathoz deleted the fix-cs-match2-cancelled-stuff branch October 23, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants