-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(match2): tournament_status
is not working
#4881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find where it was tested on dev but I tested it myself too and works 👍
/dev/hjp but i deleted it after testing |
components/match2/wikis/counterstrike/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/counterstrike/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
components/match2/wikis/counterstrike/match_group_input_custom.lua
Outdated
Show resolved
Hide resolved
Is postponed still a valid input (just without setting notplayed) or invalid entirely? |
postponed is oos for this PR |
so, invalid entirely? I just want to understand the current state, that's all. |
Yes, this PR does not improve or add support for |
finished
/status
processing faulty on cstournament_status
is not working
Summary
Fix the status/finished processing on cs by applying fallbacks a bit differently and moving status processing further up.
Also allow'postponed'
as valid not played inputHow did you test this change?
dev