Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): Add match maps legacy to aoe #4864

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

LuckeLucky
Copy link
Collaborator

Summary

Module to add the wrappers to MatchListStart and Showmatch match1 templates.

How did you test this change?

MatchMapsTeam
MatchMaps
ShowmatchTeam
Showmatch

Extra

After this I think the only templates left to wrap are ffa ... We don't have support for them yet

@LuckeLucky LuckeLucky requested a review from mbergen October 15, 2024 07:37
Copy link
Collaborator

@mbergen mbergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for all this effort!

@Rathoz Rathoz merged commit 910428f into main Oct 15, 2024
5 checks passed
@Rathoz Rathoz deleted the aoe-match-maps-legacy branch October 15, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants