refactor(match2): remove deprecated processMap, simplify subobjects #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
force-pushed
the
remove-processMap
branch
from
2057e0f to
2828c65
Compare
hjpalpha
reviewed
Oct 10, 2024
|
fwiw if on commons we make |
Yes, but requires moving existing logic from SubObjects to the Customs that needs it. Want to do it, but it would be a later stage |
hjpalpha
approved these changes
Oct 10, 2024
Rathoz
force-pushed
the
remove-processMap
branch
from
1a013d9 to
11941cd
Compare
Rathoz
added a commit
that referenced
this pull request
Oct 10, 2024
* Create Match Summary for hearthstone * Create Match Group Input for Hearthstone * Create get_match_group_copy_paste_wiki.lua * Update match_group_input_custom.lua * Update match_group_input_custom.lua * Update match_group_input_custom.lua * Update match_summary.lua * Update match_summary.lua * Update match_summary.lua * as per review * ms: fix anno * fix(ms): do not apply css to potential nil * linter * input refactor * adjust copy paste (add team support) * store chars in extradata too (to be able to condition on them) * kick unsued cars and requires * and another one * map function -> identity * fix * #4650 * update with changes from #4839 * change from #4842 * Update Hearthstone Info M2 status (#4844) * Update Hearthstone Info Based on: #4518 (comment) * Update standard/info/wikis/hearthstone/info.lua Co-authored-by: Rikard Blixt <[email protected]> --------- Co-authored-by: Rikard Blixt <[email protected]> * Create match_legacy for Hearthstone (#4846) * Create match_legacy for Hearthstone * Apply suggestions from code review Co-authored-by: hjpalpha <[email protected]> * Update components/match2/wikis/hearthstone/match_legacy.lua * Update components/match2/wikis/hearthstone/match_legacy.lua * Update components/match2/wikis/hearthstone/match_legacy.lua --------- Co-authored-by: Rikard Blixt <[email protected]> Co-authored-by: hjpalpha <[email protected]> * change from #4841 * aano wanring --------- Co-authored-by: hjpalpha <[email protected]> Co-authored-by: Rikard Blixt <[email protected]> Co-authored-by: hjpalpha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ProcessMap is no longer used
How did you test this change?
dev on r6 and val