refactor(widget): improve building part 4 - Html[] into string
#4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rathoz
changed the title
Html[] into HtmlHtml[] into string
Rathoz
force-pushed
the
widget-children-rework-part-4
branch
from
28921c5 to
fecd7a4
Compare
hjpalpha
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
make()has effectively 3 different return values.Htmlobj wrapped in an array (most common)Html-array (just in two)Widget-arrayThe end goal is to have just one return value.
Other PRs will remove the
Widget-array return value, by doing that logic as preprocessing instead.So this PR is focused on the two
Htmlcases. After some POC-ing, I found thatstringwas the best return value.So this PR changes the 2 cases of
Html-array into singleHtml, and then doestostringon basically all return values from all Widgets.This PR in independent of Parts 1, 2 & 3. Part 3 and Part 4 together are both required to make 5.
How did you test this change?
Tested on some tournament and team pages on dota2