Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(match2): refactor MGI on various wikis that do not have participants data #4705

Merged
merged 29 commits into from
Sep 13, 2024
Merged

refactor(match2): refactor MGI on various wikis that do not have participants data #4705

merged 29 commits into from
Sep 13, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Sep 9, 2024 •
edited
Loading

Summary

Refactor MGI on various wikis that do not have participants data and do not have any special stuff like e.g. score2/score3 that makes the refactors harder
(i.e. the low hanging fruits)

  • arenafps
  • battlerite
  • clashofclans
  • criticalops
  • crossfire
  • halo
  • osu
  • smite
  • splitgate
  • worldoftanks
  • zula

How did you test this change?

deployed to /dev/hjp
letting contributors do the testing
announcement messeg: https://discord.com/channels/93055209017729024/878766918880874536/1283063892972666925

hjpalpha and others added 6 commits September 10, 2024 15:11
@hjpalpha
zula
de121fa
@hjpalpha
not needed
6f2767d
@hjpalpha
not needed
3a4f084
@hjpalpha
Merge branch 'main' into refactor-match2-without-participants
a3aa2d5
@hjpalpha
smite: fix fucked up bestof stuff
7b8b229 
- smites current bestof handling is plain stupid
- this fixes most of it in a way to not break shit ...
@hjpalpha
smite: more bestof changes
8aae215 
looking at actual usage in tournaments this makes more sense compared to the bs they currently use
Rathoz
Rathoz approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rathoz
Rathoz approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@Rathoz Rathoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hjpalpha
osu: map score handling
0211348 
- can have `,` that need to be trimmed away
- can have % values that need to be handled
@hjpalpha
osu: handle map walkover display correctly
0097612
@hjpalpha hjpalpha marked this pull request as ready for review September 12, 2024 13:47
@hjpalpha hjpalpha requested a review from Rathoz September 12, 2024 13:47
@Rathoz
Copy link
Collaborator

Rathoz commented Sep 12, 2024

I'd take a stab that #4604 is needed on a few more than just osu

@hjpalpha
Copy link
Collaborator Author

retested a bit on each wiki
imo rfm

@Rathoz Rathoz merged commit 4a18613 into main Sep 13, 2024
6 checks passed
@Rathoz Rathoz deleted the refactor-match2-without-participants branch September 13, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rathoz Rathoz Rathoz approved these changes

Assignees
No one assigned
Labels
c: match2 g: arenafps ArenaFPS g: battlerite Battlerite g: clashofclans Clash of Clans g: criticalops Critical Ops g: crossfire CrossFire g: halo Halo g: osu osu g: smite Smite g: splitgate Splitgate g: worldoftanks World of Tanks g: zula ZULA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjpalpha @Rathoz