Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(match2): deadlock setup #4652

Merged
merged 6 commits into from
Aug 28, 2024
Merged

feat(match2): deadlock setup #4652

merged 6 commits into from
Aug 28, 2024

Conversation

Rathoz
Copy link
Collaborator

@Rathoz Rathoz commented Aug 26, 2024

Summary

Setup M2 for Deadlock

Copy link
Collaborator

@hjpalpha hjpalpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm on phone

please adjust #4650 after the merge ;)

@Rathoz Rathoz marked this pull request as ready for review August 27, 2024 12:06
@Rathoz Rathoz requested a review from hjpalpha August 27, 2024 12:21
@Hesketh2
Copy link
Collaborator

might worth bundling the Stylesheet (Yellow side color) into it as well if needed
#4647

@Rathoz Rathoz requested a review from hjpalpha August 28, 2024 11:27
@Rathoz
Copy link
Collaborator Author

Rathoz commented Aug 28, 2024

might worth bundling the Stylesheet (Yellow side color) into it as well if needed #4647

discussed on slack, we're skipping side colors in the display alltogether for now

@Rathoz Rathoz merged commit 429f64c into main Aug 28, 2024
5 checks passed
@Rathoz Rathoz deleted the m2-deadlock branch August 28, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants