Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(match2): stormgate MGI #4651

Merged
merged 17 commits into from
Sep 17, 2024
Merged

refactor(match2): stormgate MGI #4651

merged 17 commits into from
Sep 17, 2024

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Aug 26, 2024

Summary

  • refactor stormgate MGI based on recent refactors
  • adjust custom player ext to not throw due to timestamp instead of date string being used
  • matchsummary score display:
    • uppercase walkover score display
    • fix score display for np resulttype
    • (both needed due to MGI refactor)

How did you test this change?

dev

keep in mind

if one of the below should get merged before thiis PR adjust teh PR accordingly
if on the other hand this PR gets merged first adjuist those PRs accordingly

@Rathoz
Copy link
Collaborator

Rathoz commented Sep 9, 2024

#4650 adjustment needed

@hjpalpha hjpalpha requested a review from Rathoz September 10, 2024 05:38
@Rathoz
Copy link
Collaborator

Rathoz commented Sep 13, 2024

Changes needed due to #4645?

@hjpalpha
Copy link
Collaborator Author

Changes needed due to #4645?

yes
will do them later today
imo merge monday earliest

@hjpalpha
Copy link
Collaborator Author

retested
still think a merge on monday would be better^^

@hjpalpha hjpalpha requested a review from Rathoz September 17, 2024 13:53
@Rathoz Rathoz merged commit 33af674 into main Sep 17, 2024
5 checks passed
@Rathoz Rathoz deleted the refactor-stormgate-mGI branch September 17, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants