feat(match2): split game and match summaries on BRs #4553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
reviewed
Aug 16, 2024
hjpalpha
reviewed
Nov 13, 2024
hjpalpha
approved these changes
Nov 14, 2024
Rathoz
added a commit
that referenced
this pull request
Nov 21, 2024
* wip * wip * wip * wip * wip * change naming * remove comment * feedback 1/2 * feat(match2): split game and match summaries on BRs (#4553) * feat(match2): split game and match summaries on BRs * var rename * entry points * linter * linterv2 * changes to match what has happened in general * this function has been changed * fix? * update golden * fix deploy header * missing function * add `matchid` into data attr * pipeline? * fix matchlist (only bracket was working before) * undo this change, not intended to be pushed * add comment * comments from review * cleanup * add extra data attr * lint * fix pipeline * drop map.extradata.opponents * feedback * cleanup * remove console * update golden * add isLoading check * remove id, feedback * typo * clean code --------- Co-authored-by: Rikard Blixt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We want to be able to load match2 BR game related content dynamically when switching from one game to the other in order to not reach a size limit when loading the page.
How did you test this change?
dev
https://liquipedia.net/apexlegends/User:Kanoodles/BRTESTPAGE (JS is WIP)