feat(match2): support hearthstone #4518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fwiw from what i read on discord they have BR matches too ... |
hjpalpha
reviewed
Aug 12, 2024
components/match2/wikis/hearthstone/get_match_group_copy_paste_wiki.lua
Outdated
Show resolved
Hide resolved
Rathoz
changed the title
|
needs testing! @Kanopedia |
|
#4650 adjustment needed |
|
Update Info, missing Match Legacy |
Rathoz
added a commit
that referenced
this pull request
Oct 10, 2024
* Update Hearthstone Info Based on: #4518 (comment) * Update standard/info/wikis/hearthstone/info.lua Co-authored-by: Rikard Blixt <[email protected]> --------- Co-authored-by: Rikard Blixt <[email protected]>
* Update Hearthstone Info Based on: #4518 (comment) * Update standard/info/wikis/hearthstone/info.lua Co-authored-by: Rikard Blixt <[email protected]> --------- Co-authored-by: Rikard Blixt <[email protected]>
* Create match_legacy for Hearthstone * Apply suggestions from code review Co-authored-by: hjpalpha <[email protected]> * Update components/match2/wikis/hearthstone/match_legacy.lua * Update components/match2/wikis/hearthstone/match_legacy.lua * Update components/match2/wikis/hearthstone/match_legacy.lua --------- Co-authored-by: Rikard Blixt <[email protected]> Co-authored-by: hjpalpha <[email protected]>
Rathoz
force-pushed
the
Kanopedia-patch-1
branch
from
7fcb8ad to
4af5add
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #4645
Summary
Adding a basic match summary for 1 vs 1 tournaments in hearthstone.
(This is excluding the rare team events where individual players would need to be listed e.g aoe style.)
How did you test this change?
https://liquipedia.net/hearthstone/User:Kanoodles/Bracket