-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automated testing #3490
feat: automated testing #3490
Conversation
Yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so far, assume you want to convert all the test modules before final review
Will start with a subset, not all. Some are quite annoying as we don't have a MW environment running exactly, so need to fake or mock it |
Do we not care about |
Added |
Think I'm done with migrating tests for this PR, so feel free to review |
Why the need to implement |
Was used in a few tests indirectly, Date/Ext and Flags. It's not the complete MW implementation, but probably something good enough for now. I was looking at bringing over Scribunto as a gitmodule (not lua file), but most of their implementations are dependent on PHP, with the only PHP free libraries being ustring and html, the rest have some dependency on PHP. |
Summary
Setup automated testing using the busted framework