Skip to content

Commit

Permalink
rename function to make clear it is map related
Browse files Browse the repository at this point in the history
  • Loading branch information
hjpalpha committed Nov 8, 2024
1 parent 41fe4a3 commit a8fa8e1
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions components/match2/commons/match_group_input_util.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1131,7 +1131,7 @@ end
---@field getMapMode? fun(match: table, game: table, opponents: table[]): string?
---@field getPlayersOfMapOpponent? fun(game: table, opponent:table, opponentIndex: integer): table[]
---@field getPatch? fun(game: table): string?
---@field isFinished? fun(map: table, opponents: table[], finishedInput: string?, winnerInput: string?): boolean
---@field mapIsFinished? fun(map: table, opponents: table[], finishedInput: string?, winnerInput: string?): boolean
---@field getParticipants? fun(game: table, opponents:table[]): table ---@deprecated
---@field ADD_SUB_GROUP? boolean

Expand All @@ -1144,7 +1144,7 @@ end
--- - getMapMode(match, map, opponents): string?
--- - getPlayersOfMapOpponent(map, opponent, opponentIndex): table[]?
--- - getPatch(game): string?
--- - isFinished(map, opponents): boolean
--- - mapIsFinished(map, opponents): boolean
--- - getParticipants(map, opponents, finishedInput, winnerInput): table (DEPRECATED)
---
--- Additionally, the Parser may have the following properties:
Expand All @@ -1168,8 +1168,8 @@ function MatchGroupInputUtil.standardProcessMaps(match, opponents, Parser)
map.map = Parser.getMapName(map)
end

if Parser.isFinished then
map.finished = Parser.isFinished(map, opponents, finishedInput, winnerInput)
if Parser.mapIsFinished then
map.finished = Parser.mapIsFinished(map, opponents, finishedInput, winnerInput)
else
map.finished = MatchGroupInputUtil.mapIsFinished(map)
end
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ end
---@param finishedInput string?
---@param winnerInput string?
---@return boolean
function MapFunctions.isFinished(map, opponents, finishedInput, winnerInput)
function MapFunctions.mapIsFinished(map, opponents, finishedInput, winnerInput)
if MatchGroupInputUtil.isNotPlayed(winnerInput, finishedInput) then
return true
end
Expand Down

0 comments on commit a8fa8e1

Please sign in to comment.