Merge pull request #9 from LinuxSuRen/skip-status

feat: skip sending status if pr is -1

pkg/git.go

@@ -9,6 +9,11 @@ import (
 
 // Reconcile is the main entry of this reconciler
 func Reconcile(ctx context.Context, repoInfo RepoInformation) (err error) {
+	if repoInfo.PrNumber == -1 {
+		fmt.Println("skip due to pr number is -1")
+		return
+	}
+
 	repo := repoInfo.getRepoPath()
 	maker := NewStatusMaker(repo, repoInfo.Token)
 	maker.WithTarget(repoInfo.Target).WithPR(repoInfo.PrNumber).

pkg/git_test.go

@@ -0,0 +1,46 @@
+package pkg
+
+import (
+	"context"
+	"github.com/jenkins-x/go-scm/scm"
+	"github.com/stretchr/testify/assert"
+	"testing"
+)
+
+func TestReconcile(t *testing.T) {
+	type args struct {
+		ctx      context.Context
+		repoInfo RepoInformation
+	}
+	tests := []struct {
+		name    string
+		args    args
+		wantErr bool
+	}{{
+		name: "pr number is -1",
+		args: args{
+			repoInfo: RepoInformation{
+				PrNumber: -1,
+			},
+		},
+		wantErr: false,
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			if err := Reconcile(tt.args.ctx, tt.args.repoInfo); (err != nil) != tt.wantErr {
+				t.Errorf("Reconcile() error = %v, wantErr %v", err, tt.wantErr)
+			}
+		})
+	}
+}
+
+func TestNewStatusMaker(t *testing.T) {
+	maker := NewStatusMaker("", "")
+	assert.NotNil(t, maker)
+	assert.NotNil(t, maker.expirationCheck)
+	assert.False(t, maker.expirationCheck(nil, nil))
+	assert.False(t, maker.expirationCheck(&scm.Status{State: scm.StateSuccess},
+		&scm.StatusInput{State: scm.StateError}))
+	assert.True(t, maker.expirationCheck(&scm.Status{State: scm.StateSuccess},
+		&scm.StatusInput{State: scm.StateSuccess}))
+}

pkg/type_test.go

@@ -0,0 +1,33 @@
+package pkg
+
+import "testing"
+
+func TestRepoInformation_getRepoPath(t *testing.T) {
+	type fields struct {
+		Owner string
+		Repo  string
+	}
+	tests := []struct {
+		name   string
+		fields fields
+		want   string
+	}{{
+		name: "normal case",
+		fields: fields{
+			Owner: "owner",
+			Repo:  "repo",
+		},
+		want: "owner/repo",
+	}}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			r := RepoInformation{
+				Owner: tt.fields.Owner,
+				Repo:  tt.fields.Repo,
+			}
+			if got := r.getRepoPath(); got != tt.want {
+				t.Errorf("getRepoPath() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}