Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop #1

Closed
wants to merge 144 commits into from
Closed

Develop #1

wants to merge 144 commits into from

Conversation

yashaswi2000
Copy link
Contributor

No description provided.

rennergade and others added 21 commits September 10, 2024 15:09
* loop on accept because of cancel timeout

* update comment

* update comment

* update comment
- included git in the dockerfile
- included grcov for codecoverage
- simple refactoring of non-breaking changes
- included unit tests for pathexists

Signed-off-by: naveensrinivasan <[email protected]>
* rustfmt :- format the code.

- Included ignore based on this comment Lind-Project/safeposix-rust#238 (comment)

Signed-off-by: naveensrinivasan <[email protected]>

* included new line

Signed-off-by: naveensrinivasan <[email protected]>

---------

Signed-off-by: naveensrinivasan <[email protected]>
Co-authored-by: Justin Cappos <[email protected]>
@rennergade
Copy link
Contributor

@Yaxuan-w Can you check if this commit history is up to date? @qianxichen233 are these the commits you need?

@Yaxuan-w
Copy link
Member

@Yaxuan-w Can you check if this commit history is up to date? @qianxichen233 are these the commits you need?

Do we need to integrate in memory pipes as well?

@rennergade
Copy link
Contributor

@Yaxuan-w Can you check if this commit history is up to date? @qianxichen233 are these the commits you need?

Do we need to integrate in memory pipes as well?

No, we'll leave that out of this. We at least need it to be in the last working state. Though we should probably add the test suite and Justin's more recent fdtables updates. I'm not sure at what state this is at.

Copy link
Member

@Yaxuan-w Yaxuan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the current develop branch is almost same with older rustposix, which is the initial version. The most up-to-date version should be alice branch.

I noticed that the most import thing for this PR should be GitHub workflow and some PR template setups, so maybe we could first merge this pr to main / first merge alice into this branch. Either works for me.

@rennergade
Copy link
Contributor

lets change this to add the "alice" branch as main, and also squash commits

@rennergade rennergade closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.