automated: linux: add video output comparison test #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test takes a screenshot from video output and compares to the reference image. It is intended to test HDMI output from DUT. Signed-off-by: Milosz Wasilewski <[email protected]>
|
@roxell it looks like the linter check fail is not related to this patch. Could you take a look? |
bhcopeland
reviewed
Oct 16, 2024
| FROM python:3 | ||
|
|
||
| COPY requirements.txt /home/ | ||
| RUN python3 -m pip install opencv-python scikit-image requests |
There was a problem hiding this comment.
why don't you have all this in requirements.txt and install from there?
There was a problem hiding this comment.
It takes 1.5 hours. Both Dockerfile and requirements.txt are not needed for the test. They're added if someone would like to a) build the container to run the test in LAVA, b) run the test locally.
There was a problem hiding this comment.
ah, and using requirments.txt in Dockerfile will be tricky. If the requirements.txt changes, the layer cache will not be invalidated.
roxell
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test takes a screenshot from video output and compares to the reference image. It is intended to test HDMI output from DUT.