Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: sh-test-lib: Add riscv64 support #387

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nkbelin
Copy link
Contributor

@nkbelin nkbelin commented Oct 13, 2022

Add the support of the riscv64 platform by adding the skipgen executable for riscv64.
The binary has been generated following the "Releasing" instructions at https://github.com/Linaro/skipgen using go version go1.18.1 and goreleaser. The difference is that the upx tool to compress the executable has not been used as it does support the riscv64 architecture at the moment.

Signed-off-by: Nicolas Belin [email protected]

Add the support of the riscv64 platform by adding the skipgen
executable for riscv64.
The binary has been generated following the "Releasing" instructions
at https://github.com/Linaro/skipgen using go version go1.18.1
and goreleaser. The difference is that the upx tool to compress
the executable has not been used as it does support the riscv64
architecture at the moment.

Signed-off-by: Nicolas Belin <[email protected]>
@mwasilew
Copy link
Contributor

@roxell it's getting big, any ideas on moving skipgen binaries out of the repository? Alternatively can we separate test-definitions-core so it is easier to create derivative repositories with only required stuff?

@roxell
Copy link
Collaborator

roxell commented Oct 19, 2022

@roxell it's getting big, any ideas on moving skipgen binaries out of the repository? Alternatively can we separate test-definitions-core so it is easier to create derivative repositories with only required stuff?

Moving this discussion into an issue [1], because it deserves its own thread.
That said, this shouldn't hold back this PR.
PR looks good to me.

[1] #388

@roxell roxell merged commit ecf3bb5 into Linaro:master Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants