-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sym/cmp for HD44780 compatible displays #109
Conversation
First of all, does this really belong in the base library? Shouldn't it be part of Nice, that you marked pins 0-3 as optional and 4-7 as required! Most times, these displays are run in 4-bit mode. Some keywords would be nice. Maybe "hd44780,hitachi,lcd,character lcd"?
You named the backlight pins "LED". Was that on purpose? To quote WP:
(Changing this would also have an effect on the descriptions.) |
Thanks for taking a look at this!
First I had exactly the same thought! 😃 Mainly because HD44780 is an IC. But this sym/cmp does not represent the IC (it has many more pins) but an LCD module which is not an IC. I mean, it doesn't fit perfect for either library but somehow the base library feels more intuitive for me as most of the other optoelectronic parts are here as well.
Will do! Maybe just without hd44780, actually I think we're overusing keywords a little bit 😂 Every term already contained in the name does not need to be duplicated in the keywords.
I agree it's not intuitive. But I also saw that this seems to be the most widely used term so I think it makes more sense than something like "contrast".
To be honest, so far I'm not aware of a display calling it other than LED+/-. But probably there exist other backlight types. I just wonder whether they should have a separate component then 🤔 Most probably the driver circuit of the backlight needs to be quite different for different kinds of backlights... For example naming it BL_VCC and BL_GND (or something like that) could be misleading for an LED backlight since not a specific voltage is required, but a specific current. |
Yeah, I wasn't sure about that, so I put it in the list again 🙂 Makes sense though.
All my labelled displays call it A/K 🙂 Which isn't really better, in my opinion. You're probably right. LED is by far the most common backlight technology, and we can just assume it's using LED. Maybe we should rename the part to "with LED Backlight", but that's probably overkill. |
Hmm okay, I agree it's not better 🙈 So let's keep LED+/- for now.
I added it, so now the scope of the sym/cmp should be very clear ;) Keywords added as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (But the fixup went wrong.)
SUMMARY
There are many displays with a HD44780 compatible interface so they can all be represented by the same symbol and component. Just the backlight may or may not be available, thus added both variants.
With backlight:
Without backlight:
DATASHEETS / REFERENCES
OPEN QUESTIONS / UNRESOLVED ISSUES
None.
CHECKLIST
¹ Library Conventions: https://docs.librepcb.org/#libraryconventions
² Minor version bump if only metadata was modified (e.g. "0.1" -> "0.1.1"), major version bump if functional changes were made (e.g. "0.1" -> "0.2")
³ CC0 Public Domain License: https://en.wikipedia.org/wiki/CC0