Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sort_index #140

Merged
merged 1 commit into from
Oct 29, 2024
Merged

add sort_index #140

merged 1 commit into from
Oct 29, 2024

Conversation

chennesy
Copy link
Contributor

@chennesy chennesy commented Oct 8, 2024

Adds .sort_index() to all DataFrames that will be plotted using pandas .plot(). This addresses changes to recent versions of pandas that requires us to call .sort_index() explicitly. See issue #138.

Copy link

github-actions bot commented Oct 8, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/LibraryCarpentry/lc-python-intro/compare/md-outputs..md-outputs-PR-140

The following changes were observed in the rendered markdown documents:

 data-visualisation.md |  25 ++++++++++---------------
 fig/albany-plot-1.png | Bin 29386 -> 60020 bytes
 md5sum.txt            |   2 +-
 3 files changed, 11 insertions(+), 16 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-10-08 19:30:57 +0000

github-actions bot pushed a commit that referenced this pull request Oct 8, 2024
@chennesy chennesy requested a review from jt14den October 8, 2024 19:32
@jt14den jt14den merged commit 5a60d9f into main Oct 29, 2024
3 checks passed
@jt14den jt14den deleted the sort_index branch October 29, 2024 18:12
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : 5a60d9f
Branch  : main
Author  : Tim Dennis <[email protected]>
Time    : 2024-10-29 18:12:22 +0000
Message : Merge pull request #140 from LibraryCarpentry/sort_index

add sort_index
github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Auto-generated via `{sandpaper}`
Source  : b235ddc
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-10-29 18:13:15 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 5a60d9f
Branch  : main
Author  : Tim Dennis <[email protected]>
Time    : 2024-10-29 18:12:22 +0000
Message : Merge pull request #140 from LibraryCarpentry/sort_index

add sort_index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants