Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Points number displayed #7

Merged
merged 3 commits into from
May 22, 2024
Merged

fix: Points number displayed #7

merged 3 commits into from
May 22, 2024

Conversation

RezaRahemtola
Copy link
Member

@RezaRahemtola RezaRahemtola commented May 21, 2024

This PR can be read commit per commit:

  • Fixed a frontend issue related to points displayed right after connecting the wallet on the main chat page.
  • Removed deprecated code
  • Remove unused button

Before:
image
Because points were not fetched and a check for the NaN was missing

After the check:
image
Always 0 points, even if there is some

When fetching the points just after the wallet is successfully connected:
image

@RezaRahemtola RezaRahemtola requested a review from aliel May 21, 2024 20:47
@RezaRahemtola RezaRahemtola self-assigned this May 21, 2024
@aliel aliel merged commit 8ff5338 into main May 22, 2024
3 checks passed
@RezaRahemtola RezaRahemtola deleted the reza/fix-points-display branch May 22, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants