Add CombinedEdgeLabelMapping #317
Conversation
Encapsulate creating EdgeLabelMapping into different functions to avoid duplicate code Add UnSupportedEdgeLabelException
|
In 'RunBGPOverNeo4j.java,' currently, we are not reading the TTL file. It is necessary to specify a command-line argument to obtain the file address, similar to the file query file address. In this step, should I make modifications to that part to read from the example file instead of creating classes manually? |
|
Indeed. The command-line tool needs to be extended to provide such an argument. Please do that, but in a separate PR. In terms of implementing it, it should be implemented more like the argument for the federation catalog that we have in the other command-line tool. |
|
|
||
| @Override | ||
| public Node map(final String label) { | ||
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { |
There was a problem hiding this comment.
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { | |
| for ( final EdgeLabelMapping edgeLabelMapping : edgeLabelMappings ) { |
| } | ||
|
|
||
| public String unmap(final Node node) { | ||
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { |
There was a problem hiding this comment.
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { | |
| for ( final EdgeLabelMapping edgeLabelMapping : edgeLabelMappings ) { |
|
|
||
| @Override | ||
| public boolean isPossibleResult(final Node node) { | ||
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { |
There was a problem hiding this comment.
| for (EdgeLabelMapping edgeLabelMapping : edgeLabelMappings) { | |
| for ( final EdgeLabelMapping edgeLabelMapping : edgeLabelMappings ) { |
| try { | ||
| return edgeLabelMapping.map(label); | ||
| } | ||
| catch (IllegalArgumentException exception) {} |
There was a problem hiding this comment.
Shouldn't this be UnSupportedEdgeLabelException ?
Add CombinedEdgeLabelMapping and its tests
Encapsulate creating EdgeLabelMapping into different functions to avoid duplicate code
Add UnSupportedEdgeLabelException