Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xilo templates!! #100

Merged

Conversation

Lordfirespeed
Copy link
Contributor

No description provided.

@Xilophor
Copy link
Contributor

Removed the .NET SDK 8 warnings, as they do not apply anymore with this template. Also added a note for MonoMod users, and IDE-specific warnings. Finally added a quite note about the --help option for the dotnet new command.

Copy link
Contributor

@MaxWasUnavailable MaxWasUnavailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, but it loses a fair bit of the digestibility for new modders. Might need some minor rewriting / reconsidering in areas.

docs/dev/starting-a-mod.md Outdated Show resolved Hide resolved
docs/dev/starting-a-mod.md Show resolved Hide resolved
docs/dev/starting-a-mod.md Outdated Show resolved Hide resolved
docs/dev/starting-a-mod.md Outdated Show resolved Hide resolved
docs/dev/starting-a-mod.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MaxWasUnavailable MaxWasUnavailable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, beyond that title

docs/dev/starting-a-mod.md Show resolved Hide resolved
@Xilophor Xilophor dismissed MaxWasUnavailable’s stale review April 6, 2024 00:09

talked on discord - Max: You can approve your templates PR. I saw the email, and it's alright imo. Sorry for being pedantic about the title

@Xilophor Xilophor merged commit 2501a26 into LethalCompanyCommunity:main Apr 6, 2024
1 check passed
@Lordfirespeed Lordfirespeed deleted the Lordfirespeed-patch-1 branch April 29, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants