Skip to content

Commit

Permalink
Add ForkEditVisitor
Browse files Browse the repository at this point in the history 
As suggested by @promethe42
  • Loading branch information
@Seb35
Seb35 committed Jan 1, 2019
1 parent 7220b44 commit cefe6bf
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions server.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,7 @@ def getDiff(self, article=None, amendement=None):
#self.printTree(tree)
duralex.ResolveLookbackReferencesVisitor().visit(tree)
duralex.ForkReferenceVisitor().visit(tree)
duralex.ForkEditVisitor().visit(tree)
duralex.ResolveFullyQualifiedDefinitionsVisitor().visit(tree)
duralex.ResolveFullyQualifiedReferencesVisitor().visit(tree)
duralex.FixMissingCodeOrLawReferenceVisitor().visit(tree)
Expand Down

2 comments on commit cefe6bf

@JMLX42
Copy link
Member

@JMLX42 JMLX42 commented on cefe6bf Jan 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why you have some DuraLex code in another project.
The whole point of DuraLex is to generate a usable JSON.

@Seb35
Copy link
Member Author

@Seb35 Seb35 commented on cefe6bf Jan 3, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Durafront is basically a DuraLex server and Web interface. It can be discussed exactly what should be in DuraLex in a "main" entry point and what should be left to the users of DuraLex, I’ve no specific opinion on this, it’s just a matter of a dozen of lines there or elsewhere. Also, I wrote Durafront originally as a quick prototype for a Web interface of DuraLex/SedLex; now, given it works, the exact dispatching of roles could be improved by moving the lines; in particular, the "merge" operation coded here in Durafront (described in SedLex #1) could be moved to SedLex.

Beyond the exact dispaching of roles, I think the next big step is how we scale into a complete product: do we do an API? what specs exactly? how do we retrieve (or not) the data like amendments and law proposal? what diffs exactly do we provide, particularly do we chain DuraLex when the result is itself an amendment? do we do a specific web interface? and perhaps the more important: now that the whole pipeline works (for the average user), what promotion/communication/links with other projects do we do? (I will be in the Open Office the Fridays 18 and 25 January if you want/can come.)

Please sign in to comment.