Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core/AuctionHouse] Modernize auction house #337

Merged
merged 3 commits into from
Sep 7, 2024

Conversation

jasongdove
Copy link

@jasongdove jasongdove commented Sep 7, 2024

This updates the auction house manager code to match TCPP as much as possible. Future PRs might involve porting improvements from TC.

Updating the auction house code required updating the characters database, so I also enabled auto updates there.

  • 2024_09_06_xx_characters_update_tables.sql will need to be applied manually
  • Afterward, the worldserver can update the auction house tables in the characters db if characters db updates are enabled in the worldserver config

Because of the db changes, all items will be sold to the highest bidder or returned to the owner on server startup, as part of the migration. Future auctions will behave normally.

Note that this does not fix the existing bug where bidding on an item will immediately show it as outbit in the bids tab.

@leelf00
Copy link

leelf00 commented Sep 7, 2024

New tables and data missing in sql/base/characters.sql

@jasongdove
Copy link
Author

New tables and data missing in sql/base/characters.sql

These have been updated/added.

@leelf00 leelf00 merged commit f6db48d into Legends-of-Azeroth:master Sep 7, 2024
4 checks passed
@jasongdove jasongdove deleted the auction-house-rework branch September 9, 2024 17:28
@5840174
Copy link

5840174 commented Oct 12, 2024

The auction house item does not display the seller's name
is it because of this change?

@jasongdove
Copy link
Author

The auction house item does not display the seller's name
is it because of this change?

No - the commit before this PR also does not show the seller's name.

@jasongdove
Copy link
Author

@5840174 names will be fixed with #359

@5840174
Copy link

5840174 commented Oct 15, 2024

Well done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants