feat: profile main process #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amilajack
commented
Oct 13, 2022
| @@ -1,4 +1,4 @@ | |||
| /* eslint global-require: off, no-console: off, promise/always-return: off */ | |||
| /* eslint global-require: off, no-console: off, promise/always-return: off, import/first: off */ | |||
There was a problem hiding this comment.
disabled import/first here to allow properly ordering imports. palette needs to start the profiler before other imports, since they can impact startup performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr enables palette's main process profiling and network tracing features. these features are secure and don't expose any personal information.
to the build working locally I had to bump sqlite3 and electron-rebuild to work around MadLittleMods/node-usb-detection#163. the bug prevents apple m1 machines from natively building node-gyp in certain scenarios.
I've packaged the app locally and confirmed everything works without errors :)