feat: Web3mail & dataProtector integration #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Torof is attempting to deploy a commit to the Ledgity Team on Vercel. A member of the Team first needs to authorize it. |
feat(web3mail): Add API routes for storage ability
…ata and email sending Using the IExec toolsuite to add the possibility for user to give the right to send them email without sharing their email address
hapetherw
suggested changes
Jul 10, 2024
| } | ||
|
|
||
| export function getAutomaticSigner(): WalletEip1193Provider | null { | ||
| console.log('SENDER_PRIVATE_KEY:', SENDER_PRIVATE_KEY ? 'Set' : 'Not set'); |
There was a problem hiding this comment.
Can you remove these console logs?
|
|
||
| try { | ||
| const provider = new ethers.providers.JsonRpcProvider(RPC_URL); | ||
| const wallet = new ethers.Wallet(SENDER_PRIVATE_KEY, provider); |
There was a problem hiding this comment.
Could you also describe the use case of this function(getAutomaticSigner)?
I guess it's not preferred to disclose private key as env, we need to think about it.
There was a problem hiding this comment.
the address is uniquely for sending emails. No funds on it. No problem there
env.mjs
Outdated
| IPINFO_TOKEN: z.string(), | ||
| SCORECHAIN_API_KEY: z.string(), | ||
| AML_ALERT_WEBHOOK: z.string().url(), | ||
| // TWITTER_CLIENT_ID: z.string().optional(), |
There was a problem hiding this comment.
Apply optional fields instead of comments like other PRs.
Co-authored-by: Torof <[email protected]>
feat: add bull for iexec batch email send
Co-authored-by: Torof <[email protected]>
Co-authored-by: Torof <[email protected]>
Co-authored-by: Torof <[email protected]>
Co-authored-by: Torof <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding dataProtector & web3Mail from IExec toolsuite