Feat/worskpace #93
Merged
Feat/worskpace #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledger_device_rust_sdk/Cargo.toml
Outdated
| @@ -0,0 +1,29 @@ | |||
| [package] | |||
| name = "ledger_device_rust_sdk" | |||
| version = "0.3.0" | |||
There was a problem hiding this comment.
Did you bumped any of the crate version? Should we?
There was a problem hiding this comment.
No I did not bump anything, it is just a workspace refactoring and there is no modification in the SDK itself.
|
you need to add a licence at the root. |
That's the case actually |
My bad, that's normal if I don't see it in the diff as it's already there... |
yhql
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New repo architecture hosting Ledger Rust SDK workspace