Uniswap protocol update #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeutin-ledger
force-pushed
the
fbe/post_trip_improvements
branch
2 times, most recently
from
0230695 to
5f3599d
Compare
Add sweep method support Add proper support for native ETH amount sending
fbeutin-ledger
force-pushed
the
fbe/post_trip_improvements
branch
from
5f3599d to
86ed146
Compare
fbeutin-ledger
force-pushed
the
fbe/post_trip_improvements
branch
from
4b92795 to
e382deb
Compare
| @@ -100,7 +100,6 @@ static uint8_t prepare_reading_next_input(context_t *context) { | |||
| PRINTF("Preparing to read V3_SWAP_EXACT_OUT\n"); | |||
| context->next_param = INPUT_V3_SWAP_EXACT_OUT_LENGTH; | |||
| break; | |||
| case PERMIT2_TRANSFER_FROM: | |||
There was a problem hiding this comment.
so it seems that we can remove the enum in this file and all the things related in test (uniswap_crafter.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.