Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web3check feature #681

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Conversation

cedelavergne-ledger
Copy link
Contributor

Description

The web3check feature includes:

  • Add setting to enable web3check

Changes include

  • New feature (non-breaking change that adds functionality)
  • Tests
  • Documentation

@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_web3check branch 5 times, most recently from 491a62b to e1747c5 Compare December 5, 2024 12:21
@cedelavergne-ledger cedelavergne-ledger force-pushed the cev/B2CA-1881_web3check branch 2 times, most recently from ba465b5 to 692047c Compare December 6, 2024 12:04
ux_approve_tx(false);
} else {
// W3Checks enabled
checkTxSimulationParams();

Check warning

Code scanning / CodeQL

Expression has no effect Warning

This expression has no effect (because
checkTxSimulationParams
has no external side effects).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant