B2CA-1838: Implement swap #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedelavergne-ledger
force-pushed
the
cev/B2CA-1838_implement-swap
branch
25 times, most recently
from
ca7b314
to
de9eaaf
Compare
cedelavergne-ledger
force-pushed
the
cev/B2CA-1838_implement-swap
branch
4 times, most recently
from
d69e21e
to
fc4b618
Compare
- SignTx - SignTXCVote - SignTXPlutus Alonzo & Babbage
- Move _test.c into a dedicated directory, cleanup files accordingly - Move each feature into dedicated directories - Move UI related into a dedicated directory, with additional split for bagl/nbgl
cedelavergne-ledger
force-pushed
the
cev/B2CA-1838_implement-swap
branch
from
ebd9521
to
cdd0d45
Compare
cedelavergne-ledger
requested review from
fbeutin-ledger and
tdejoigny-ledger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the SWAP in app-cardano. This also requires:
Note: the fail test on the CI workflow is only due to the version check. Those tests are located in a separate repository (https://github.com/vacuumlabs/ledgerjs-cardano-shelley), where I do not have the permission to create a PR to update it
Checklist
develop