Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app : features, UI, tests, CI. #31

Merged
merged 15 commits into from
Nov 16, 2023
Merged

Update app : features, UI, tests, CI. #31

merged 15 commits into from
Nov 16, 2023

Conversation

agrojean-ledger
Copy link
Contributor

@agrojean-ledger agrojean-ledger commented Oct 25, 2023

Update the boilerplate so it has the same features as the C boilerplate (https://github.com/LedgerHQ/app-boilerplate) :

  • Use new UI gadgets to have richer and more standard main menus.
  • Implement standard command processing (get pubkey, sign tx, get app name, get version...) with display when necessary.
  • Add Ragger functional tests (same as the C boilerplate).

⚠️ The nanos-ui PR has to be merged first : LedgerHQ/ledger-device-rust-sdk#95

ℹ️ there is no "app state" management implemented as in the C app. Why ? Because I forgot.

@agrojean-ledger agrojean-ledger marked this pull request as draft October 25, 2023 14:40
@agrojean-ledger agrojean-ledger force-pushed the update-app branch 5 times, most recently from 3b55c6d to 3349a71 Compare October 26, 2023 12:41
@agrojean-ledger agrojean-ledger changed the title Add new main menu based on MultiPageMenu gadget. Update app features, UI. Add tests and CI. Nov 7, 2023
@agrojean-ledger agrojean-ledger changed the title Update app features, UI. Add tests and CI. Update app : features, UI, tests, CI. Nov 7, 2023
@agrojean-ledger agrojean-ledger force-pushed the update-app branch 5 times, most recently from aa56193 to dbe8174 Compare November 15, 2023 14:09
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for Cargo.toml (did not perform a deep review of the sources TBH...)

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@agrojean-ledger agrojean-ledger marked this pull request as ready for review November 16, 2023 14:26
Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@agrojean-ledger agrojean-ledger merged commit 0aafd40 into main Nov 16, 2023
4 checks passed
@agrojean-ledger agrojean-ledger deleted the update-app branch November 16, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants