-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app : features, UI, tests, CI. #31
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrojean-ledger
force-pushed
the
update-app
branch
5 times, most recently
from
October 26, 2023 12:41
3b55c6d
to
3349a71
Compare
agrojean-ledger
changed the title
Add new main menu based on MultiPageMenu gadget.
Update app features, UI. Add tests and CI.
Nov 7, 2023
agrojean-ledger
changed the title
Update app features, UI. Add tests and CI.
Update app : features, UI, tests, CI.
Nov 7, 2023
agrojean-ledger
force-pushed
the
update-app
branch
5 times, most recently
from
November 15, 2023 14:09
aa56193
to
dbe8174
Compare
agrojean-ledger
force-pushed
the
update-app
branch
from
November 15, 2023 14:42
493c252
to
b57d5bd
Compare
yogh333
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for Cargo.toml (did not perform a deep review of the sources TBH...)
Code cleanup.
agrojean-ledger
force-pushed
the
update-app
branch
from
November 16, 2023 14:15
97e3e2e
to
a132cd4
Compare
yogh333
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the boilerplate so it has the same features as the C boilerplate (https://github.com/LedgerHQ/app-boilerplate) :
ℹ️ there is no "app state" management implemented as in the C app. Why ? Because I forgot.