Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing issue #192
Used native android function to get user device uniq number:
https://developer.android.com/reference/android/os/UserManager#getSerialNumberForUser(android.os.UserHandle)
Couldn't find native flutter/dart plugin method. Path_provider PR for Android downloads is closed: flutter/plugins#4559
Additionally jumped on interested bug, with get_it and setting download path. First time loading app worked, however, on second load (after app removed from process) it failed:
get_it_impl.dart failed assertion instanceFactory.isReady
. Making wait while all registry values are collected, helped to solved and avoid app crash.I haven't added any tests for download paths, as basically would need to mockup different users profiles: (requires either time either ideas, how to automate this case)
Simple testing scenario:
Additionally, worth to close/kill app and launch again to check if it opens.
Code Review Checklist