Updated Hooks to v12 #2934
Updated Hooks to v12 #2934
Conversation
|
Foundry hasn't officially documented the appv2 hooks, we should probably look into those and write our own? Maybe steal from v13? Can be a separate update |
|
Are the AppV2 hooks ticketed? If not could you make sure they are? |
| * @param group - The group being deconstructed | ||
| */ | ||
| type TearDownGroup< | ||
| G extends ReturnType<typeof CanvasGroupMixin> = ReturnType<typeof CanvasGroupMixin<CanvasGroupMixin.BaseClass>>, |
There was a problem hiding this comment.
It'd also be useful here.
| * @param group - The group being drawn | ||
| */ | ||
| type DrawGroup< | ||
| G extends ReturnType<typeof CanvasGroupMixin> = ReturnType<typeof CanvasGroupMixin<CanvasGroupMixin.BaseClass>>, |
There was a problem hiding this comment.
Maybe this suggests we should have an interface and possible namespace named CanvasGroup available in the global scope.
I kind of like the idea of being able to write CanvasGroup.Any.
On that note I'm pretty sure ReturnType<typeof CanvasGroupMixin> is the same thing as ReturnType<typeof CanvasGroupMixin<CanvasGroupMixin.BaseClass>> because when generics are left off they seem to default to their generic constraint.
So I think this could be CanvasGroup.Any = CanvasGroup.Any or possibly CanvasGroupMixin.Any.
There was a problem hiding this comment.
I'll write that up as a ticket?
EDIT: Done #2937
Closes #2573