Skip to content
Build

Bump rustls from 0.22.2 to 0.22.4 in /bootstrap (#349) #743

Sign in to view logs

Bump rustls from 0.22.2 to 0.22.4 in /bootstrap (#349)

Bump rustls from 0.22.2 to 0.22.4 in /bootstrap (#349) #743

GitHub Actions / clippy failed May 25, 2024 in 0s

clippy

14 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 14
Warning 0
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check failure on line 1486 in src/world/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/world/mod.rs:1486:13
     |
1486 |             info.lines = self.0.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.lines.clone_from(&self.0)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1486 in src/world/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/world/mod.rs:1486:13
     |
1486 |             info.lines = self.0.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `info.lines.clone_from(&self.0)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1043 in src/ui/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/ui/mod.rs:1043:13
     |
1043 |             self.last_text = self.text.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_text.clone_from(&self.text)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 884 in src/ui/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
   --> src/ui/mod.rs:884:13
    |
884 |             self.last_texture = self.texture.clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_texture.clone_from(&self.texture)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1043 in src/ui/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/ui/mod.rs:1043:13
     |
1043 |             self.last_text = self.text.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_text.clone_from(&self.text)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 149 in src/ui/logo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
   --> src/ui/logo.rs:149:13
    |
149 |             text.text = self.text_strings[text_index as usize].clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `text.text.clone_from(&self.text_strings[text_index as usize])`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 884 in src/ui/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
   --> src/ui/mod.rs:884:13
    |
884 |             self.last_texture = self.texture.clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_texture.clone_from(&self.texture)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 149 in src/ui/logo.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
   --> src/ui/logo.rs:149:13
    |
149 |             text.text = self.text_strings[text_index as usize].clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `text.text.clone_from(&self.text_strings[text_index as usize])`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1706 in src/server/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/server/mod.rs:1706:17
     |
1706 |                 top_inventory.write().cursor = item.clone();
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `top_inventory.write().cursor.clone_from(&item)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1706 in src/server/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/server/mod.rs:1706:17
     |
1706 |                 top_inventory.write().cursor = item.clone();
     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `top_inventory.write().cursor.clone_from(&item)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 44 in src/screen/background.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
  --> src/screen/background.rs:44:9
   |
44 |         self.last_path = path.clone();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_path.clone_from(&path)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 44 in src/screen/background.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
  --> src/screen/background.rs:44:9
   |
44 |         self.last_path = path.clone();
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.last_path.clone_from(&path)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check failure on line 1696 in src/render/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/render/mod.rs:1696:13
     |
1696 |             t.name = old.name.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `t.name.clone_from(&old.name)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
     = note: `-D clippy::assigning-clones` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`

Check failure on line 1696 in src/render/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient 

error: assigning the result of `Clone::clone()` may be inefficient
    --> src/render/mod.rs:1696:13
     |
1696 |             t.name = old.name.clone();
     |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `t.name.clone_from(&old.name)`
     |
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
     = note: `-D clippy::assigning-clones` implied by `-D warnings`
     = help: to override `-D warnings` add `#[allow(clippy::assigning_clones)]`
View more details on GitHub Actions