Capella -> to Deneb update #18
Conversation
Sidu28
changed the base branch from
master
to
partial_withdrawal_related_changes
prove_validator.go
Outdated
| @@ -15,7 +15,7 @@ type VerifyWithdrawalCredentialsCallParams struct { | |||
| ValidatorFields [][]Bytes32 `json:"validatorFields"` | |||
| } | |||
|
|
|||
| func (epp *EigenPodProofs) ProveValidatorWithdrawalCredentials(oracleBlockHeader *phase0.BeaconBlockHeader, oracleBeaconState *capella.BeaconState, validatorIndices []uint64) (*VerifyWithdrawalCredentialsCallParams, error) { | |||
| func (epp *EigenPodProofs) ProveValidatorWithdrawalCredentials(oracleBlockHeader *phase0.BeaconBlockHeader, oracleBeaconState *deneb.BeaconState, validatorIndices []uint64) (*VerifyWithdrawalCredentialsCallParams, error) { | |||
There was a problem hiding this comment.
No i mean everywhere. If its for deneb, name it deneb. if it's for fork1 name it fork1
There was a problem hiding this comment.
The other way (easier) is that you name them the same thing and just change argument types. let's not go halfway though
There was a problem hiding this comment.
hmm not sure about that, its a bit much. it makes more sense to me to have separate functions for where it matters. I don't mind having the same name and different types tho, although it might make it a little less explicit - tho I don't think go lang lets you delcare similarly named functions in the same package
| @@ -39,7 +40,7 @@ func NewEigenPodProofs(chainID uint64, oracleStateCacheExpirySeconds int) (*Eige | |||
| }, nil | |||
| } | |||
|
|
|||
| func (epp *EigenPodProofs) ComputeBeaconStateRoot(beaconState *capella.BeaconState) (phase0.Root, error) { | |||
| func (epp *EigenPodProofs) ComputeBeaconStateRoot(beaconState *deneb.BeaconState) (phase0.Root, error) { | |||
There was a problem hiding this comment.
can we just define new functions on *deneb.BeaconState? like
func (s *deneb.BeaconState) ComputeBeaconStateRoot() (phase0.Root, error) {not sure if go allows it because its from another module
fullWithdrawalProof_Latest.json
Outdated
| @@ -0,0 +1,162 @@ | |||
| { | |||
There was a problem hiding this comment.
pls move these out of the top level folder
Deneb cleanup
Sidu28
changed the base branch from
partial_withdrawal_related_changes
to
master
Upgrading proof gen from capella spec to deneb spec, with support for both capella and deneb spec proofs.
DO NOT MERGE