Gpsanant/fix pending checkpoint case #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous logic did not handle the case where there was pending checkpoint on the pod so some validators were proven withdrawn. This would lead to them not being active, which would have them not be counted in the previous
regGweinor in thesumPreviousBeaconBalancesGwei, but they would be in thepodBalanceGwei.This would lead to validators that are proven withdrawn in a pending checkpoint simply not existing in the "previous balance".
In order to avoid this case, we simply calculate the previous balance only on the execution layer by asking the delegation manager for the actively restaked shares and the shares in the withdrawal queue.