Partial Withdrawal Oracle Slot Proof #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpsanant
reviewed
Jan 8, 2024
| @@ -0,0 +1,161 @@ | |||
| { | |||
gpsanant
reviewed
Jan 8, 2024
| // Note: this slot and slot root proof are used for partial withdrawal proofs to ensure that the oracle root slot is after the specified range of blocks requested by the user | ||
| verifyAndProcessWithdrawalCallParams.StateRootProof.Slot = oracleBlockHeader.Slot | ||
|
|
||
| verifyAndProcessWithdrawalCallParams.StateRootProof.SlotRootProof, err = ProveSlotAgainstBlockHeader(oracleBlockHeader) |
There was a problem hiding this comment.
do we need this now? why wasn't it here before?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a slot proof to the verify withdrawal call params. We need this additional slot proof to ensure that the oracle root slot is after the specified range of blocks requested by the user. This is a key part of the risc0/zk partial withdrawal design.
This PR also removes validator balance proofs and replaces them with validator container proofs, as per the new M2 mainnet contracts