[v0.2.0] Major CLI Refactor / Cleanup #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrower95
commented
Aug 14, 2024
| Usage: "Print the calldata for all associated transactions, but do not execute them. Note that some transactions have an order dependency (you cannot submit checkpoint proofs if you haven't started a checkpoint) so this may require you to get your pod into the correct state before usage.", | ||
| Required: false, | ||
| Destination: &simulateTransaction, | ||
| } |
There was a problem hiding this comment.
this is now just the default state of the tool.
wadealexc
reviewed
Aug 14, 2024
wadealexc
reviewed
Aug 14, 2024
wadealexc
reviewed
Aug 14, 2024
Comment on lines
+53
to
+55
| if !args.NoPrompt && !args.SimulateTransaction { | ||
| core.PanicIfNoConsent(core.StartCheckpointProofConsent()) | ||
| } |
There was a problem hiding this comment.
Can we do the inverse of this boolean statement?
if args.NoPrompt || args.SimulateTransaction
The current version is making my head hurt :(
There was a problem hiding this comment.
dam this is what i get for coding past 11
wadealexc
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/commandpackage--proofand--output-- we now just output calldata to stdout as JSON by default. If you want to save to a file, pipe the JSON output to a file, and later use a tool like foundry's cast to submit :)main.goisn't a mess.Workflows:
--sender <privateKey>.--senderand instead just parse the JSON output from the command -- we providetoandcalldata, sign this with whatever tool you want and submit to network.--verbose.--sender, If you want to submit any of this in CI without user prompts, pass--no-prompt.Hopefully this simplifies everyone's workflows!
Examples
credential proofs
checkpoint start
