Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[payment] transactor ping payment vault contract #827

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[payment] transactor ping payment vault contract #827

wants to merge 3 commits into from

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Oct 22, 2024

Why are these changes needed?

filling in the transactor functions to read the payment vault contract on-chain

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ian-shim ian-shim Awaiting requested review from ian-shim

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hopeyen